Compare commits

..

No commits in common. "1f90ae20ad6fc0b5ed11e0065e8054b7fb62deb6" and "210a8167b8e515f3bde28f66221c18df6554f4f2" have entirely different histories.

2 changed files with 2 additions and 18 deletions

View file

@ -7,15 +7,8 @@ struct OutdatedPackage: Codable, Equatable {
/// Menu label, e.g. "wget 1.21 1.22" /// Menu label, e.g. "wget 1.21 1.22"
var label: String { var label: String {
let installed = installedVersions.map(Self.displayVersion).joined(separator: ", ") let installed = installedVersions.joined(separator: ", ")
return "\(name) \(installed)\(Self.displayVersion(currentVersion))" return "\(name) \(installed)\(currentVersion)"
}
/// Some casks (e.g. claude: "1.20186.9,69f150a4c9") version themselves
/// as "user-facing-version,build-id" the part after the comma only
/// matters for brew's own download URL, never for display.
static func displayVersion(_ version: String) -> String {
String(version.split(separator: ",", maxSplits: 1)[0])
} }
} }

View file

@ -64,15 +64,6 @@ final class BrewParserTests: XCTestCase {
XCTAssertEqual(package.label, "wget 1.21.3 → 1.21.4") XCTAssertEqual(package.label, "wget 1.21.3 → 1.21.4")
} }
func testParseOutdatedJSON_packageLabel_stripsBuildIdAfterComma() {
let package = OutdatedPackage(
name: "claude",
installedVersions: ["1.20185.0,5e8f0a1b2c3d4e5f6a7b8c9d0e1f2a3b4c5d6e7f"],
currentVersion: "1.20186.9,69f150a4c9316d5c8cd7b9f130ed583d15c0383e"
)
XCTAssertEqual(package.label, "claude 1.20185.0 → 1.20186.9")
}
// MARK: - parseVersion // MARK: - parseVersion
func testParseVersion_picksFirstLine() { func testParseVersion_picksFirstLine() {