maxsoch/BrewBar
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases 3 Wiki Activity

fix: confirm before Upgrade All, warn that running apps may close

Browse source 
brew upgrade also upgrades casks, and replacing a cask quits the running
app (e.g. the browser) with no warning. Upgrade All now shows an NSAlert
listing the outdated packages and warning that running apps may be
closed, with a Cancel option.

NSApp.activate is needed because BrewBar is an accessory app (no Dock
icon) — without it the modal alert can appear behind other windows.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
maxsoch 2026-07-06 21:29:23 +02:00
parent e579ac1d56
commit e47455b3f8
1 changed files with 26 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
BrewBar/BrewBarApp.swift
View file

@ -237,6 +237,8 @@ class AppDelegate: NSObject, NSApplicationDelegate {
}
@objc func upgradeAll() {
guard confirmUpgrade() else { return }
statusMenuItem.title = "Upgrading..."
runBrew("update") { _ in
@ -246,6 +248,30 @@ class AppDelegate: NSObject, NSApplicationDelegate {
}
}
func confirmUpgrade() -> Bool {
let alert = NSAlert()
alert.alertStyle = .warning
if cachedOutdated.isEmpty {
alert.messageText = "Upgrade all outdated packages?"
} else {
alert.messageText = "Upgrade \(cachedOutdated.count) package\(cachedOutdated.count == 1 ? "" : "s")?"
}
var info = "Apps upgraded as casks (like a web browser) may be closed and replaced while running, without further warning. Save your work first."
if !cachedOutdated.isEmpty {
info += "\n\n" + cachedOutdated.joined(separator: "\n")
}
alert.informativeText = info
alert.addButton(withTitle: "Upgrade")
alert.addButton(withTitle: "Cancel")
// accessory app: bring the alert to the front, otherwise it can appear behind other windows
NSApp.activate(ignoringOtherApps: true)
return alert.runModal() == .alertFirstButtonReturn
}
/// ✅ SMART refresh (uses cache)
@objc func refreshOutdatedList() {
// if fetched in last 5s → uses cache