From 9ab8af79a4228019f6d96e1de5ea0de3d7bdd1af Mon Sep 17 00:00:00 2001 From: maxsoch Date: Mon, 6 Jul 2026 21:38:10 +0200 Subject: [PATCH] remove redundant "Refresh List" from the Outdated submenu The main Refresh action already refetches everything; the submenu button duplicated it. Its only handler, forceRefreshOutdated, is removed too as nothing else referenced it. Co-Authored-By: Claude Fable 5 --- BrewBar/BrewBarApp.swift | 7 ------- 1 file changed, 7 deletions(-) diff --git a/BrewBar/BrewBarApp.swift b/BrewBar/BrewBarApp.swift index 9ced921..28fa121 100644 --- a/BrewBar/BrewBarApp.swift +++ b/BrewBar/BrewBarApp.swift @@ -55,7 +55,6 @@ class AppDelegate: NSObject, NSApplicationDelegate { menu.addItem(NSMenuItem(title: "📦 Upgrade All", action: #selector(upgradeAll), keyEquivalent: "u")) let outdatedItem = NSMenuItem(title: "📋 Outdated", action: nil, keyEquivalent: "") outdatedSubmenu = NSMenu() - outdatedSubmenu.addItem(NSMenuItem(title: "Refresh List", action: #selector(forceRefreshOutdated), keyEquivalent: "")) outdatedItem.submenu = outdatedSubmenu menu.addItem(outdatedItem) menu.addItem(NSMenuItem(title: "📜 Logs", action: #selector(showLogs), keyEquivalent: "l")) @@ -273,11 +272,6 @@ class AppDelegate: NSObject, NSApplicationDelegate { return alert.runModal() == .alertFirstButtonReturn } - /// ✅ FORCE refresh (menu button) - @objc func forceRefreshOutdated() { - fetchOutdated() - } - func fetchOutdated() { setMenuBarIcon("brewbar-updating") @@ -298,7 +292,6 @@ class AppDelegate: NSObject, NSApplicationDelegate { func updateOutdatedMenu(with lines: [String]) { outdatedSubmenu.removeAllItems() - outdatedSubmenu.addItem(NSMenuItem(title: "Refresh List", action: #selector(forceRefreshOutdated), keyEquivalent: "")) if lines.isEmpty { outdatedSubmenu.addItem(NSMenuItem(title: "✅ All up to date", action: nil, keyEquivalent: ""))